New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup Literal.hash and Literal.eq by accessing directly _da… #1321

Merged

nicholascar merged 2 commits into RDFLib:master from rchateauneu:speedup_term_hash

Jun 29, 2021

Contributor

rchateauneu commented May 18, 2021 •

edited

Loading

Literal.hash and Literal.eq use self.datatype and self. language properties. It is faster to directly use the private members Literal._dataype and Literal.__language.

Test importing orkg.nt

Before:

After:


          Speedup Literal.__hash__ and Literal.__eq__ by accessing directly _da…

282a8b7

…tatype and _language.

coveralls commented May 18, 2021

Coverage decreased (-0.08%) to 75.627% when pulling 282a8b7 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

4 similar comments

coveralls commented May 18, 2021

Coverage decreased (-0.08%) to 75.627% when pulling 282a8b7 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

coveralls commented May 18, 2021

Coverage decreased (-0.08%) to 75.627% when pulling 282a8b7 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

coveralls commented May 18, 2021

Coverage decreased (-0.08%) to 75.627% when pulling 282a8b7 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

coveralls commented May 18, 2021

Coverage decreased (-0.08%) to 75.627% when pulling 282a8b7 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

coveralls commented May 18, 2021 •

edited

Loading

Coverage remained the same at 75.705% when pulling 42c90d9 on rchateauneu:speedup_term_hash into 58b23fd on RDFLib:master.

Contributor Author

rchateauneu commented May 18, 2021 •

edited

Loading

It failed only Python 3.7, but 3.6 and 3.8 worked OK. This is strange because the changes are very simple.

The failed test is:

ERROR: test_query_with_added_rdf_prolog (test.test_sparqlstore.SPARQLStoreDBPediaTestCase)
...
  File "/usr/local/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
OSError: [Errno 99] Cannot assign requested address

I tend to think that it is a transient error related to a temporary network problem.

Is it possible to rerun a build on the same PR ?

rchateauneu mentioned this pull request

Implemented function translateAlgebra. This functions takes a SPARQL … #1322

Merged


          Added comments.

42c90d9

rchateauneu marked this pull request as ready for review

May 20, 2021 06:52

This was referenced May 21, 2021

Speedup ntriples parser #1300

Closed

Speedup NTriples parser #1297

Closed

nicholascar self-requested a review

June 28, 2021 23:41

nicholascar approved these changes

View reviewed changes

Member

nicholascar left a comment

Don't worry about the "cannot assign address" test failure you're noticing: that's spurious and won't prevent this PR going through.

nicholascar merged commit e4d975a into RDFLib:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet